Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete
From: Jean Delvare <hidden>
Date: 2009-02-10 15:56:14
Also in:
linux-i2c
From: Jean Delvare <hidden>
Date: 2009-02-10 15:56:14
Also in:
linux-i2c
On Tue, 10 Feb 2009 08:59:57 -0600, Timur Tabi wrote:
On Fri, Feb 6, 2009 at 8:00 AM, Timur Tabi [off-list ref] wrote:quoted
The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the wait will be interrupted, returning an error. It is better to let the I2C operation finished before the process exits. It is safe to use wait_event_timeout() instead, because the timeout will allow the process to exit if the I2C bus hangs. It's also better to allow the I2C operation to finish, because unacknowledged I2C operations can cause the I2C bus to hang. Signed-off-by: Timur Tabi <redacted>Jean, Could you pick up this patch for 2.6.30?
No, that's something for either Ben Dooks (Cc'd) or the powerpc tree. -- Jean Delvare