Re: [PATCH v2 1/4] Add platform support for AmigaOne

On Wed, Feb 04, 2009 at 10:35:31PM +0100, Gerhard Pircher wrote:

-------- Original-Nachricht --------

quoted

Datum: Wed, 4 Feb 2009 21:59:41 +0100
Von: Gabriel Paubert [off-list ref]
An: Benjamin Herrenschmidt [off-list ref]
CC: Gerhard Pircher <redacted>, linuxppc-dev list <redacted>
Betreff: Re: [PATCH v2 1/4] Add platform support for AmigaOne

quoted

On Wed, Feb 04, 2009 at 02:50:07PM +1100, Benjamin Herrenschmidt wrote:

quoted

quoted

+ hose->first_busno = bus_range ? bus_range[0] : 0;
+ hose->last_busno = bus_range ? bus_range[1] : 0xff;
+
+ setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0);

Minor in the context of amigaone but still... the above should come
from the device-tree... I suppose those are really just IO space
addresses cf8 and cfc, in which case, an option is to call that first:

Hmm, the first is feC...,the other one feE..., 2Mbytes apart.

I don't know the hardware but I've never seen something like that.
Of course a typo is always a possibility...

The Pegasos 1 uses the same northbridge and chrp_find_bridges() calls
setup_indirect_pci() with the same addresses.

As a proud owner, I concur that those numbers are correct...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.