Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
From: Kumar Gala <hidden>
Date: 2009-02-17 14:13:04
Also in:
lkml
On Feb 17, 2009, at 6:44 AM, [off-list ref] <dayu@datangmobile.cn > wrote:
From: Da Yu <redacted> Date: Tue, 17 Feb 2009 19:58:20 +0800 Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23) Signed-off-by: Da Yu <redacted> ---
Please provide a bit more description as to why this fixes the issue. - k
quoted hunk ↗ jump to hunk
--- a/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:18.000000000 +0800 +++ b/arch/powerpc/sysdev/ipic.c 2009-02-17 20:05:28.000000000 +0800@@ -561,8 +561,7 @@ static void ipic_ack_irq(unsigned int vispin_lock_irqsave(&ipic_lock, flags); - temp = ipic_read(ipic->regs, ipic_info[src].pend); - temp |= (1 << (31 - ipic_info[src].bit)); + temp = 1 << (31 - ipic_info[src].bit); ipic_write(ipic->regs, ipic_info[src].pend, temp); spin_unlock_irqrestore(&ipic_lock, flags);@@ -581,8 +580,7 @@ static void ipic_mask_irq_and_ack(unsigntemp &= ~(1 << (31 - ipic_info[src].bit)); ipic_write(ipic->regs, ipic_info[src].mask, temp); - temp = ipic_read(ipic->regs, ipic_info[src].pend); - temp |= (1 << (31 - ipic_info[src].bit)); + temp = 1 << (31 - ipic_info[src].bit); ipic_write(ipic->regs, ipic_info[src].pend, temp); spin_unlock_irqrestore(&ipic_lock, flags);