On Jan 28, 2009, at 3:31 AM, Benjamin Herrenschmidt wrote:

quoted

quoted

We are using the patch I emailed.  It's ugly in that it hard-codes  
the
Freescale vendor ID, but it works for us.

I guess I'm confused what the actual breakage is beyond some printk
messages.

We "fixup" the resources in fsl_pcibios_fixup_bus() so Ben's change
shouldn't have an impact.  Does something actually stop functioning?

I think the problem comes from my patch that "detects" closed bridge
windows, which uses the PCI_COMMAND register as a clue, and it seems
that your bridges don't properly support IO enable in there..

Yeah but I don't see why that's an issue.

Because after your code (pcibios_uninitialized_bridge_resource) we'll  
call ppc_md.pcibios_fixup_bus() and that will fix things up.

So I'm wondering if this is really a bug or just annoying printk's  
that are confusing.

- k