Re: [PATCH] powerpc/83xx: Fix few build errors with CONFIG_QUICC_ENGINE=n
From: Anton Vorontsov <hidden>
Date: 2008-12-16 18:44:53
On Tue, Dec 16, 2008 at 12:18:07PM -0600, Kumar Gala wrote: [..]
quoted
This patch implements traditional way of !QE case handling. Alternative version is coming (w/o ifdefs in the board files). p.s. I don't know if it is 2.6.28 material...what's the state of this patch vs the alternate version?
Pros of the alternative version:
- No #ifdefs in .c files.
Cons of the alternative version:
- For this code (assuming QE=n):
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL)
par_io_init(np);
GCC can still issue the of_find_node_by_name() call. (I wonder if
there is any way to tell gcc that particular function doesn't
produce any side-effects so that gcc can optimize it away too).
It's up to you to decide which version you want to merge.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2