Re: [PATCH] [RFC] Pass a valid token to rats_call() in phyp-dump code.
From: Manish Ahuja <hidden>
Date: 2008-12-16 18:39:08
Yes, That is required. It is in the patches that I sent to Ben, Paul & Brad. I just waiting to post it with other patches. Acked-by: Manish Ahuja <redacted> Tony Breeds wrote:
quoted hunk ↗ jump to hunk
ibm_configure_kernel_dump, is passed as the token to rtas_call() but I cannot see where it is initialised. Set it to something sane? Signed-off-by: Tony Breeds <redacted> --- arch/powerpc/platforms/pseries/phyp_dump.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/arch/powerpc/platforms/pseries/phyp_dump.c b/arch/powerpc/platforms/pseries/phyp_dump.c index 16e659a..6cf35cd 100644 --- a/arch/powerpc/platforms/pseries/phyp_dump.c +++ b/arch/powerpc/platforms/pseries/phyp_dump.c@@ -414,6 +414,8 @@ static int __init phyp_dump_setup(void) of_node_put(rtas); } + ibm_configure_kernel_dump = rtas_token("ibm,configure-kernel-dump"); + print_dump_header(dump_header); dump_area_length = init_dump_header(&phdr); /* align down */
-- -- Manish Ahuja Linux RAS Engineer. IBM Linux Technology Center mahuja@us.ibm.com 512-838-1928, t/l 678-1928.