Re: [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for managing endpoint queues
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2008-12-24 22:54:32
Also in:
lkml
On Wed, 24 Dec 2008, Anton Vorontsov wrote:
Follow these changes for the FHCI driver: commit e9df41c5c5899259541dc928872cad4d07b82076 Author: Alan Stern [off-list ref] Date: Wed Aug 8 11:48:02 2007 -0400 USB: make HCDs responsible for managing endpoint queues
On the whole this looks good.
quoted hunk ↗ jump to hunk
--- a/drivers/usb/host/fhci-q.c +++ b/drivers/usb/host/fhci-q.c@@ -200,6 +200,9 @@ void urb_complete_free(struct fhci_hcd *fhci, struct urb *urb) else urb->status = 0; } + + usb_hcd_unlink_urb_from_ep(fhci_to_hcd(fhci), urb); + spin_unlock(&fhci->lock); usb_hcd_giveback_urb(fhci_to_hcd(fhci), urb, urb->status);
For the future you might think about not using urb->status at all. The intention is eventually to remove that field. Alan Stern