Re: [PATCH v1] RS485 support for MPC5200x_psc_uart
From: Wolfram Sang <hidden>
Date: 2008-11-27 22:39:20
Attachments
- signature.asc [application/pgp-signature] 197 bytes
From: Wolfram Sang <hidden>
Date: 2008-11-27 22:39:20
Hello Hans, On Mon, Nov 17, 2008 at 04:27:45PM +0100, Lehmann, Hans (Ritter Elektronik) wrote:
Criticism is welcome
Well, there are still some issues concerning coding-style and design, but those can be worked out, I guess. Still, there is one conceptual question I'd like to ask: Have you seen the TxRTS feature in Mode Register 2? It looks to me that it does the same (in hardware) what you achieve with the *_rts_clear-function and the TX_EMPTY interrupt. Or am I wrong? Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry