Re: [PATCH] Add support for the nwp serial device
From: Benjamin Krill <hidden>
Date: 2008-11-23 21:46:18
Also in:
linux-serial
From: Benjamin Krill <hidden>
Date: 2008-11-23 21:46:18
Also in:
linux-serial
* Andrew Morton | 2008-11-21 13:22:44 [-0800]:
(does a powerpc allmodconfig) drivers/serial/nwpserial.c:443: warning: data definition has no type or storage class drivers/serial/nwpserial.c:443: warning: type defaults to 'int' in declaration of 'console_initcall' drivers/serial/nwpserial.c:443: warning: parameter names (without types) in function declaration drivers/serial/nwpserial.c:400: warning: 'nwpserial_console_init' defined but not used The file fails to include linux/init.h. It should do so, but that doesn't fix the above. Apparently it hasn't been tested as a kernel module...
Console support doesn't work when the driver is build as module, all other serial drivers did this with a further configuration option. Will send an updated patch which fixes this and the other issues.