Re: [PATCH] gianfar: Omit TBI auto-negotiation based on device tree
From: Nate Case <hidden>
Date: 2008-11-03 18:57:06
Also in:
netdev
From: Nate Case <hidden>
Date: 2008-11-03 18:57:06
Also in:
netdev
On Thu, 2008-10-30 at 18:07 -0700, Trent Piepho wrote:
But more relevant to your serdes problem, I also have a patch that prevents restarting serdes auto-negotiation if the serdes link is already up. My SGMII PHY will auto-negotiate, but it takes about 3 seconds. Avoiding an unnecessary 3 second auto-negotiation when the gianfar device is opened lets me cut my power-on to DHCP completion time in half. I wonder if this would also fix your problem, without needing to add the extra workaround?
I just verified that your patch solves my problem without the need for
my workaround. So at this point, it looks like we can drop this patch
("Omit TBI auto-negotiation based on device tree").
I tested when booting the kernel in U-Boot both via both TFTP and flash
(I was worried that your patch may only fix things for the TFTP boot
case, but that wasn't the case fortunately).
Thanks for the patch!
--
Nate Case [off-list ref]