Re: [PATCH][V2] [powerpc] GPIO: Adding new Xilinx driver
From: Grant Likely <hidden>
Date: 2008-10-27 16:53:06
On Mon, Oct 27, 2008 at 10:39 AM, John Linn [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This driver supports the Xilinx XPS GPIO IP core which has the typical GPIO features. Signed-off-by: Kiran Sutariya <redacted> Signed-off-by: John Linn <redacted> --- V2 - Updated based on Anton's comments drivers/gpio/Kconfig | 15 ++-- drivers/gpio/Makefile | 1 + drivers/gpio/xilinx_gpio.c | 235 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 244 insertions(+), 7 deletions(-) create mode 100644 drivers/gpio/xilinx_gpio.cdiff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 7f2ee27..12a8006 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig@@ -127,13 +135,6 @@ config GPIO_PCF857X This driver provides an in-kernel interface to those GPIOs using platform-neutral GPIO calls. -config GPIO_TWL4030 - tristate "TWL4030, TWL5030, and TPS659x0 GPIOs" - depends on TWL4030_CORE - help - Say yes here to access the GPIO signals of various multi-function - power management chips from Texas Instruments. -
Looks like you've got some colateral damage in here. Otherwise looks right to me. When you repost, please add my Signed-off-by line between yours and Kiran's since I did a bunch of hacking on this driver too. Also, make use you post it to the LKML. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.