Re: [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls
From: Anton Vorontsov <hidden>
Date: 2008-10-22 10:46:18
Also in:
linux-i2c, lkml
On Wed, Oct 22, 2008 at 02:36:41PM +0400, Anton Vorontsov wrote:
On Tue, Oct 21, 2008 at 09:22:48PM -0700, David Brownell wrote:quoted
On Tuesday 21 October 2008, Benjamin Herrenschmidt wrote:quoted
The notifier can be registered before the devices, though it's a little bit fishy and fragile. Easier I suppose to just have OF specific hooks in the bus code.Like what I suggested: "chip-aware OF glue drivers". The relevant bus code being the "of_platform_bus_type" infrastructure. Example: instead of Anton's patch #6 modifying the existing pca953x driver, an of_pca953x driver that knows how to poke around in the OF device attributes to (a) create the pca953x_platform_data, (b) call i2c_register_board_info() to make that available later, and then finally (c) vanish, since it's not needed any longer.Heh. You tell me my first approach: http://ozlabs.org/pipermail/linuxppc-dev/2008-May/056730.html (mmc_spi) The OF people didn't like the patch which was used to support this approach: http://ozlabs.org/pipermail/linuxppc-dev/2008-May/056728.html
Though, I think I'll able to persuade Grant that two registration paths
are inevitable (i.e. for simple devices we should use
drivers/of/of_{i2c,spi}.c and for complex cases we'll have to have
another method of registration).
The board info has another problem though. We can't remove it, thus we can't implement module_exit() for the 'OF glue'.
And try to solve this problem... maybe then things will begin to move forward. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2