Re: [PATCH] ibm_newemac: Fix new MAL feature handling
From: Jeff Garzik <hidden>
Date: 2008-10-21 05:18:25
Also in:
lkml, netdev
Benjamin Herrenschmidt wrote:
On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote:quoted
On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote:quoted
quoted
drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri' drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function) drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.) drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri' drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob': drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function)That's annoying, I'll have a look.Support for new features needed by the PPC 405EZ boards introduced some errors in the MAL and EMAC feature handling. This broke 'allmodconfig' builds as CONFIG_PPC_DCR_NATIVE is not set for those. This patch fixes these errors by wrapping the code in the appropriate #ifdefs. Signed-off-by: Josh Boyer <redacted>Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- Jeff, this breaks build, I'll put it in powerpc.git for a merge today,
ACK