Thread (24 messages) 24 messages, 4 authors, 2008-10-14

Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks

From: Christian Borntraeger <hidden>
Date: 2008-10-13 08:47:39
Also in: lkml, virtualization

Am Montag, 13. Oktober 2008 schrieb Benjamin Herrenschmidt:
quoted
 	if (--hp->count == 0) {
-		if (hp->ops->notifier_del)
-			hp->ops->notifier_del(hp, hp->data);
-
 		/* We are done with the tty pointer now. */
 		hp->tty = NULL;
 		spin_unlock_irqrestore(&hp->lock, flags);
 
+		if (hp->ops->notifier_del)
+			hp->ops->notifier_del(hp, hp->data);
+
I will try. Of course the risk here is that the interrupt happens
after we set hp->tty to NULL, so we probably need to check within the
interrupt handler for a NULL tty. I haven't checked if that's the case
(I'm not in front of the code right now).
Even the old code (without my patch) was setting hp->tty to NULL before doing 
the irq_free, so that should be ok.

Christian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help