RE: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost
From: Li Yang-R58472 <hidden>
Date: 2008-09-04 06:45:33
-----Original Message----- From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com]=20 Sent: Monday, September 01, 2008 9:35 PM To: Kumar Gala Cc: linuxppc-dev@ozlabs.org; Li Yang-R58472 Subject: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add=20 support for USBHost =20 Various changes to support QE USB Host on a MPC8360E-MDS board: =20 - Update the device tree per QE USB bindings; - Configure QE Par IO; - Set up BCSR for both USB Host and Peripheral modes; - Add timer (GTM) node; - Add gpio-controller node for BCSR13 bank; - Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO. =20 The work is loosely based on Li Yang's patch[1], which is=20 used to support peripheral mode only. =20 [1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html =20 The s-o-b line of the original patch preserved here. =20 Signed-off-by: Li Yang <redacted> Signed-off-by: Anton Vorontsov <redacted>
{snip}quoted hunk ↗ jump to hunk
@@ -297,11 +328,20 @@ };=20 usb@6c0 { - compatible =3D "qe_udc"; + compatible =3D "fsl,mpc8360-qe-usb", + "fsl,mpc8323-qe-usb"; reg =3D <0x6c0 0x40 0x8b00 0x100>; interrupts =3D <11>; interrupt-parent =3D <&qeic>; - mode =3D "slave"; + fsl,fullspeed-clock =3D "clk21"; + fsl,lowspeed-clock =3D "brg9"; + gpios =3D <&qe_pio_b 2 0 /* USBOE */ + &qe_pio_b 3 0 /* USBTP */ + &qe_pio_b 8 0 /* USBTN */ + &qe_pio_b 9 0 /* USBRP */ + &qe_pio_b 11 0 /* USBRN */ + &bcsr13 5 0 /* SPEED */ + &bcsr13 4 1>; /* POWER */
Nothing against this node. But I don't think gpio nodes can replaces = par_io nodes. Gpios are focusing on the pins which are directly = manipulated by the core, but par_io are for pins used by internal SoCs. - Leo