Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

On Wed, 20 Aug 2008 10:45:47 -0400
Josh Boyer [off-list ref] wrote:

On Wed, 2008-08-20 at 08:15 -0600, Grant Likely wrote:

quoted

On Wed, Aug 20, 2008 at 7:33 AM, Arnd Bergmann [off-list ref] wrote:

quoted

On Tuesday 19 August 2008, Josh Boyer wrote:

quoted

This adds a common board file for almost all of the "simple" PowerPC 44x
boards that exist today.  This is intended to be a single place to add
support for boards that do not differ in platform support from most of the
evaluation boards that are used as reference platforms.  Boards that have
specific requirements or custom hardware setup should still have their own
board.c file.

The code looks correct, but since this is going to be example code
that may get copied into other platforms, I would take extra care
for coding style:

I second Arnd's comments.  Otherwise, this looks pretty good to me.

You should fix 52xx with the same for loop change then, since I
blatantly most of this file from you ;)

           ^ stole

/me sighs.

josh