Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

On Wed, Aug 13, 2008 at 10:10 AM, Scott Wood [off-list ref] wrote:

John Rigby wrote:

quoted

As I type this I'm coming to like the primary flag more and more.
I'm willing to change it to 'fsl,primary-pci-bridge' though I don't
really agree with your argument against the generic name.  It is in
the context of an 'fsl,pci-whatever' node so it does not have to be
specific.

It *does* have to be specific; what if "primary" comes to mean something
else in a broader context?

exactly

quoted

And maybe generic is good, a universal generic solution would be to
require all primary pci nodes to have the property then
pci_process_bridge_OF_ranges could get it out of the device node
instead of having it passed in.

The "universal generic solution" would be to encode legacy I/O devices in
the device tree, and fix Linux to not assume that they're all on one bus.

... So my argument is; since Linux is broken in this regard, hard code
the fix into the device driver and don't pollute the device tree with
stuff that doesn't actually describe the hardware.  In this case,
primary is entirely a Linux internal implementation detail that will
change in the future.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.