Thread (7 messages) flat view 7 messages, 4 authors, 2008-08-07

Re: [PATCH] i2c-mpc: suppress I2C device probing

From: Grant Likely <hidden>
Date: 2008-08-07 14:33:26

On Thu, Aug 7, 2008 at 5:07 AM, Jean Delvare [off-list ref] wrote:
On Thu, 07 Aug 2008 12:50:11 +0200, Jochen Friedrich wrote:
quoted
Hi Wolfgang,
quoted
  $ grep I2C_CLASS_HWMON *
  i2c-cpm.c:        .class          = I2C_CLASS_HWMON | I2C_CLASS_SPD,
  i2c-mpc.c:        .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
  i2c-ibm_iic.c:    adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
  i2c-pasemi.c:     smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
  i2c-mv64xxx.c:    drv_data->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;

It would be consequent to remove them as well.
ACK for the i2c-cpm part.
No objection on my side. It's really up to each platform to choose the
way they want to handle i2c device creation, and stick to it.

As I understand it, the removal of the adapter class needs to be
synchronized with platform code changes. Thus it might make sense to
push these through their respective arch trees, rather than the i2c
tree.
All right, I'm happy to pick these patches up if nobody objects.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help