Scott Wood wrote:

John Rigby wrote:

quoted

   I would like to use mpc83xx_add_bridge for 5121.  This is why I
   moved it to fsl_pci.c.  It currently uses get_immrbase and adds
   0x8300 and 0x8304 to it to pass to setup_indirect_pci as the
   cfg_addr, and cfg_data addresses.

   I'm more than willing to change mpc83xx_add_bridge to not use
   get_immrbase.  One simple solution is to pass the cfg_addr and
   cfg_data addresses in.  If that seems ok then thats what I will do.

We should really be putting those addresses in the "reg" property of 
the PCI node.

-Scott

Yes, which is what fsl_add_bridge does it.