Thread (8 messages) 8 messages, 2 authors, 2008-07-28

Re: [PATCH 3/4] powerpc: rtc_cmos_setup: assign interrupts only if there is i8259 PIC

From: Kumar Gala <hidden>
Date: 2008-07-28 12:54:32

On Jun 11, 2008, at 6:04 PM, Anton Vorontsov wrote:
i8259 PIC is disabled on MPC8610HPCD boards, thus currently rtc-cmos
driver fails to probe.

To fix the issue, we lookup the device tree for "chrp,iic" and
"pnpPNP,000" compatible devices, and if not found we do not assign RTC
IRQ and assuming that i8259 was disabled.

Though this patch fixes RTC on some boards (and surely should not  
break
any other), the whole approach is still broken. We can't easily fix  
this
though, because old device trees do not specify i8259 interrupts for  
the
cmos rtc node.

Signed-off-by: Anton Vorontsov <redacted>
---
arch/powerpc/sysdev/rtc_cmos_setup.c |   23 +++++++++++++++++------
1 files changed, 17 insertions(+), 6 deletions(-)
applied.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help