On Jul 24, 2008, at 9:46 AM, Laurent Pinchart wrote:

Hi Kumar,

On Friday 18 July 2008, Kumar Gala wrote:

quoted

On Jul 18, 2008, at 10:30 AM, Jochen Friedrich wrote:

quoted

quoted

On Jun 18, 2008, at 12:08 PM, Laurent Pinchart wrote:

quoted

+#if defined(CONFIG_CPM2) || defined(CONFIG_8xx_GPIO)
+
+struct cpm2_ioports {
+	u32 dir, par, sor, odr, dat;
+	u32 res[3];
+};
+

is this really common for both CPM2 and 8xx?  if so why the name?

It is common to CPM2 and Port E of CPM1.

but ports a-d are different on cpm1?  I guess I'd like to see both
patches to understand the commonality and differences.

As Jorgen mentionned, both patches are still in patchwork:

http://patchwork.ozlabs.org/linuxppc/patch?id=19045
http://patchwork.ozlabs.org/linuxppc/patch?id=19386

Would it be possible for you to review them in time for 2.6.27 ?

Yes.  Can you resend the first patch and add some details in the  
commit message about the fact we can also use this code for 8xx/CPM1  
port E.

- k