Thread (5 messages) flat view 5 messages, 4 authors, 2008-07-24

Re: Getting GPIO to build again

From: Anton Vorontsov <hidden>
Date: 2008-07-24 12:08:39

On Wed, Jul 23, 2008 at 11:34:28PM -0400, Jon Smirl wrote:
This lets me build again, no clue if it is the correct fix.
No, I don't think that this is correct. OF_GPIO isn't GENERIC_GPIO
provider. GPIO controllers should select GENERIC_GPIO instead.

Though, with this patch:
http://lkml.org/lkml/2008/7/10/269

We'll only have to select ARCH_WANT_OPTIONAL_GPIOLIB. Maybe for whole
powerpc.
quoted hunk ↗ jump to hunk
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 3a7a11a..e14dbe3 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -3,6 +3,7 @@ config OF_DEVICE
        depends on OF && (SPARC || PPC_OF)

 config OF_GPIO
+       select GENERIC_GPIO
        def_bool y
        depends on OF && PPC_OF && HAVE_GPIO_LIB
        help
-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help