Thread (4 messages) 4 messages, 3 authors, 2008-07-16

Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c

From: Grant Likely <hidden>
Date: 2008-07-16 22:22:35

On Wed, Jul 16, 2008 at 4:15 PM, Sean MacLennan [off-list ref] wrote:
On Sat, 28 Jun 2008 13:16:16 -0600
"Grant Likely" [off-list ref] wrote:
quoted
On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang
[off-list ref] wrote:
quoted
If an I2C device node does not specify an interrupt, the .irq
member of the board_info struct was set to -1. This caused crashes
on following irq_dispose_mappings. Leave it NO_IRQ as returned from
irq_of_parse_and_map. (Suggesting -1 as 'i2c-no-irq' used to be a
bug in linux/i2c.h.)

Signed-off-by: Wolfram Sang <redacted>
Acked-by: Grant Likely <redacted>
I just hit this while trying to get the at24 driver working. So:

Acked-by: Sean MacLennan <redacted>
Okay, I'll pick this one up.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help