Thread (11 messages) flat view 11 messages, 5 authors, 2008-07-08

Re: [PATCHv3] Power5,Power6 BSR driver

From: Stephen Rothwell <hidden>
Date: 2008-07-08 04:52:45

Hi Sonny,

On Mon, 7 Jul 2008 21:58:12 -0500 Sonny Rao [off-list ref] wrote:
+static int bsr_create_devs(struct device_node *bn)
+{
+		cur->bsr_device = device_create(bsr_class, NULL,
+						cur->bsr_dev,
+						cur->bsr_name);
+		if (!cur->bsr_device) {
+			printk(KERN_ERR "device_create failed for %s\n",
+			       cur->bsr_name);
+			cdev_del(&cur->bsr_cdev);
+			goto out_err;
+		}
+		dev_set_drvdata(cur->bsr_device, cur);
device_create() is being removed in 2.6.27 because the above introduces a
race, use device_create_drvdata() instead.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help