Thread (4 messages) flat view 4 messages, 3 authors, 2008-07-08

Re: powerpc: Add proper reference to dma_mask

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-07-08 04:28:24

On Tue, 2008-07-08 at 13:54 +1000, Stephen Rothwell wrote:
Hi Vitaly,

On Tue, 8 Jul 2008 03:12:56 +0400 Vitaly Bordug [off-list ref] wrote:
quoted
+++ b/arch/powerpc/kernel/of_platform.c
@@ -76,6 +76,9 @@ struct of_device* of_platform_device_create(struct device_node *np,
 		return NULL;
 
 	dev->dma_mask = 0xffffffffUL;
+	dev->dev.dma_mask = &dev->dma_mask;
That is done in of_device_alloc which is called just above.
So the problem might just be that coherent_dma_mask isn't set.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help