Re: [PATCH] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.

On 7/7/08 4:40 PM, Benjamin Herrenschmidt wrote:

On Mon, 2008-07-07 at 16:31 -0700, Grant Erickson wrote:

quoted

 #define RGMII_FER_GMII(idx)    (0x7 << ((idx) * 4))
+#define RGMII_FER_MII(idx)     (0x7 << ((idx) * 4))

Hrm... the setting of the register is exactly the same right ?

Do we -really- need that ?

Would you prefer?

    +#define RGMII_FER_MII(idx)     RGMII_FER_GMII(idx)

Having the "extra" mnemonic makes the code end up looking less like a typo
and more like a conscious decision: "Yes, we know MII and GMII are the same
setting, but we're being explicit about it."

-Grant