Re: [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used

On Mon, Jul 7, 2008 at 12:47 AM, Benjamin Herrenschmidt
[off-list ref] wrote:

On Tue, 2008-07-01 at 10:52 -0700, John Linn wrote:

quoted

The legacy serial driver does not work with an 8250
type UART that uses reg-offset and reg-shift. This
change updates the driver so it doesn't find the UART
when those properties are present on the UART in the
device tree for soc devices.

I have some problems with this patch:

 - First if the properties are present but their value match the
register layout of a standard UART, we will bail out... not nice.

Okay, that can be fixed.

 - Why don't we just implement support for the reg-shift and
offset instead ?

We can do this, but this patch was simpler for solving the immediate
problem in .26

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.