Re: [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

On Wed, Jul 02, 2008 at 11:50:43AM +0200, Takashi Iwai wrote:

At Tue, 01 Jul 2008 17:53:30 -0600,
Grant Likely wrote:

quoted

diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
index 18f28ac..c5736e5 100644
--- a/sound/soc/Kconfig
+++ b/sound/soc/Kconfig

@@ -23,6 +23,12 @@ config SND_SOC
 	  This ASoC audio support can also be built as a module.  If so, the module
 	  will be called snd-soc-core.
 
+config SND_SOC_OF
+	tristate "OF helpers for SoC audio support"
+	depends on SND_SOC
+	---help---
+	  Add support for OpenFirmware device tree descriptions of sound device
+

This is a helper module and not necessarily manually selectable.
Better to make the other driver selecting this.

Yes, you're right.  I hadn't put too much thought into the Kconfig stuff
for this patch because, at the moment, I'm viewing this as a temporary
solution until ASoCv2 is merged.

Which raises another question: Liam and Mark, what is your opinion on
merging this driver?  Is it something that you would merge with the v1
API and then rework it when v2 is merged?  Or would you rather it be
kept out until v2 is ready?  I haven't even looked at the v2 API yet, so
I don't know how much rework is involved.

Cheers,
g.