RE: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used

-----Original Message-----
From: John Linn [mailto:john.linn@xilinx.com]
Sent: Tuesday, July 01, 2008 9:32 AM
To: linuxppc-dev@ozlabs.org; grant.likely@secretlab.ca;

paulus@samba.org; benh@kernel.crashing.org;

dwg@au1.ibm.com; jwboyer@linux.vnet.ibm.com; Stephen Neuendorffer
Cc: John Linn
Subject: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't

used

=

The legacy serial driver does not work with an 8250
type UART that uses reg-offset and reg-shift. This
change updates the driver so it doesn't find the UART
when those properties are present on the UART in the
device tree for soc devices.
=

Signed-off-by: John Linn <redacted>
Acked-by: Grant Likely <redacted>
---
=

 arch/powerpc/kernel/legacy_serial.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
=

b/arch/powerpc/kernel/legacy_serial.c

device_node *np,

 	if (of_get_property(np, "clock-frequency", NULL) =3D=3D NULL)
 		return -1;
=

+	/* if reg-shift and offset, don't try to use it */
+	if ((of_get_property(np, "reg-shift", NULL) !=3D NULL) &&
+		(of_get_property(np, "reg-offset", NULL) !=3D NULL))
+		return -1;

Um, shouldn't this be || ?

+
 	/* if rtas uses this device, don't try to use it as well */
 	if (of_get_property(np, "used-by-rtas", NULL) !=3D NULL)
 		return -1;
--
1.5.2.1
=

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.