RE: [PATCH v2 4/5] spi: Add OF binding support for SPI busses

-----Original Message-----
From: linuxppc-dev-bounces+b11801=3Dfreescale.com@ozlabs.org=20
[mailto:linuxppc-dev-bounces+b11801=3Dfreescale.com@ozlabs.org]=20
On Behalf Of Grant Likely
Sent: 2008?7?3? 9:03
To: linuxppc-dev@ozlabs.org;=20
spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org
Cc: david-b@pacbell.net; fabrizio.garetto@gmail.com
Subject: [PATCH v2 4/5] spi: Add OF binding support for SPI busses
=20
From: Grant Likely <redacted>
=20
This patch adds support for populating an SPI bus based on data in the
OF device tree.  This is useful for powerpc platforms which use the
device tree instead of discrete code for describing platform layout.
=20
Signed-off-by: Grant Likely <redacted>
---
=20
 drivers/of/Kconfig     |    6 +++
 drivers/of/Makefile    |    1 +
 drivers/of/of_spi.c    |   88=20
++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/of_spi.h |   18 ++++++++++
 4 files changed, 113 insertions(+), 0 deletions(-)
=20

diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 3a7a11a..edd6e92 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig

@@ -13,3 +13,9 @@ config OF_I2C
 	depends on PPC_OF && I2C
 	help
 	  OpenFirmware I2C accessors
+
+config OF_SPI
+	def_tristate SPI
+	depends on OF && PPC_OF && SPI
+	help
+	  OpenFirmware SPI accessors

diff --git a/drivers/of/Makefile b/drivers/of/Makefile
index 548772e..4c3c6f8 100644
--- a/drivers/of/Makefile
+++ b/drivers/of/Makefile

@@ -2,3 +2,4 @@ obj-y =3D base.o
 obj-$(CONFIG_OF_DEVICE) +=3D device.o platform.o
 obj-$(CONFIG_OF_GPIO)   +=3D gpio.o
 obj-$(CONFIG_OF_I2C)	+=3D of_i2c.o
+obj-$(CONFIG_OF_SPI)	+=3D of_spi.o

diff --git a/drivers/of/of_spi.c b/drivers/of/of_spi.c
new file mode 100644
index 0000000..ed0c807
--- /dev/null
+++ b/drivers/of/of_spi.c

@@ -0,0 +1,88 @@
+/*
+ * SPI OF support routines
+ * Copyright (C) 2008 Secret Lab Technologies Ltd.
+ *
+ * Support routines for deriving SPI device attachments from=20

the device
+ * tree.
+ */
+
+#include <linux/of.h>
+#include <linux/device.h>
+#include <linux/spi/spi.h>
+#include <linux/of_spi.h>
+
+/**
+ * of_register_spi_devices - Register child devices onto the SPI bus
+ * @master:	Pointer to spi_master device
+ * @np:		parent node of SPI device nodes
+ *
+ * Registers an spi_device for each child node of 'np' which=20
has a 'reg'
+ * property.
+ */
+void of_register_spi_devices(struct spi_master *master,=20
struct device_node *np)
+{
+	struct spi_device *spi;
+	struct device_node *nc;
+	const u32 *prop;
+	const char *sprop;
+	int rc;
+	int len;
+
+	for_each_child_of_node(np, nc) {
+		/* Alloc an spi_device */
+		spi =3D spi_alloc_device(master);
+		if (!spi) {
+			dev_err(&master->dev, "spi_device alloc=20
error for %s\n",
+				nc->full_name);
+			continue;
+		}
+
+		/* Device address */
+		prop =3D of_get_property(nc, "reg", &len);
+		if (!prop || len < sizeof(*prop)) {
+			dev_err(&master->dev, "%s has no 'reg'=20
property\n",
+				nc->full_name);
+			continue;
+		}
+		spi->chip_select =3D *prop;
+
+		/* Mode (clock phase/polarity/etc.) */
+		if (of_find_property(nc, "spi,cpha", NULL))
+			spi->mode |=3D SPI_CPHA;
+		if (of_find_property(nc, "spi,cpol", NULL))
+			spi->mode |=3D SPI_CPOL;