Thread (5 messages) 5 messages, 4 authors, 2008-06-29

Re: [RFC] Non-numbered ibm iic driver

From: Sean MacLennan <hidden>
Date: 2008-06-29 03:43:41

On Sat, 28 Jun 2008 23:25:05 -0400
"Jon Smirl" [off-list ref] wrote:
On 6/28/08, Sean MacLennan [off-list ref] wrote:
quoted
This is a patch to the ibm iic driver that uses the non-numbered
 i2c call and therefore does not need an index. Instead, it
registers the ibm iic, then walks all the child nodes and adds
them. This is required for new style drivers, old style drivers
"just work".
Check out the code in drivers/of/of_i2c.c. Can you use it instead?
Sure can. The for loop can be replaced with:

	of_register_i2c_devices(adap, np);

I have tested it and it works. I guess it makes sense to put of_i2c.c
under drivers/of, but if it had been under drivers/i2c, I would have
noticed it ;)

But is this the way we want to go? I personally like it. It gets rid of
the index and gets rid of the i2c_register_board_info() from the
platform code.

Cheers,
   Sean
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help