Re: [PATCH 1/2] Added support for PRTLVT based boards (MPC5121)

On Thu, Jun 12, 2008 at 10:19 PM, David Gibson
[off-list ref] wrote:

On Thu, Jun 12, 2008 at 08:10:47AM -0600, Grant Likely wrote:
[snip]

quoted

quoted

+               i2ccontrol@1760 {
+                       compatible = "fsl,mpc5121-i2c-ctrl";
+                       reg = <0x1760 0x8>;
+               };
+
+               diu@2100 {

(nitpick) There is a recommended practice that says node names should
be generic as much as possible, so I think this should probably be
video@2100.  The compatible value is fine.

If this is a video display device, the recommended generic name is
"display@XX", not "video@XX".

heh; oops.  I should know better and I stand corrected.  :-)

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.