Re: [PATCH 02/19] powerpc: Split processor entitlement retrieval and gathering to helper routines

Hi Robert,

On Thu, 12 Jun 2008 17:08:58 -0500 Robert Jennings [off-list ref] wrote:

-		seq_printf(m, "R4=0x%lx\n", h_entitled);
-		seq_printf(m, "R5=0x%lx\n", h_unallocated);
-		seq_printf(m, "R6=0x%lx\n", h_aggregation);
-		seq_printf(m, "R7=0x%lx\n", h_resource);

This changes a user visible interface by removing the above.  I don't
know if this matters (probably not), but it should be mentioned in the
changelog.

+	if (new_entitled)
+		*new_weight = current_weight;
+
+	if (new_weight)
+		*new_entitled = current_entitled;

These look fishy - checking one pointer for NULL and then updating via
the other pointer.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/