Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

David Gibson wrote:

On Thu, Jun 05, 2008 at 08:43:51AM -0500, Kumar Gala wrote:

quoted

On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote:

[snip]

quoted

quoted

+			timebase-frequency = <0>;	// from U-Boot
+			bus-frequency = <0>;	// from U-Boot
+			clock-frequency = <0>;	// from U-Boot

u-boot will add this for us so no need for them.

I think it's worth including them (with the comments) for
documentation purposes though.  Plus allowing the bootloader and
bootwrapper to just replace property values without resizing or
inserting is somewhat worthwhile of itself.

I understand your point and while testing the new blob, I realized that
 the DTB image created with

 $ make ARCH=powerpc tqm8548.dtb

does not work because work space is missing:

  ## Flattened Device Tree blob at 00900000
     Booting using the fdt blob at 0x900000
     Loading Device Tree to 007fe000, end 007ff8e0 ... OK
  WARNING: could not create /chosen FDT_ERR_NOSPACE.
  ERROR: /chosen node create failed - must RESET the board to recover.

As I see it, I have to define DTS_FLAGS manually

  $ export DTS_FLAGS="-R4 -S0x3000"
  $ make ARCH=powerpc tqm8548.dtb

to get a working blob. Is that the intended behavior?

Wolfgang.