Re: All your drivers are belong to us [was WARNING: mutexes are preferredfor single holder semaphores]

On Wed, 07 May 2008 16:36:30 +0200
"Detlev Zundel" [off-list ref] wrote:

It also happened that a driver once posted for what the customer
thought was a completely specific device of his own today supports
lots of different boards from at least four different manufacturers."

The wording is of course not exact but I hope I caught the spirit of
what Greg wanted to say.  So yes, please post the driver - maybe Greg
KH will tunnel it into mainline...

I agree with the sentiment. However, it is hard enough to get
legitimate drivers into the kernel. The drivers I mentioned do not
come close to following the Linux kernel coding spec.

Just to start, they use 2 character spaces for indentation :( They are
full of ifdefs since we need to support the whole gamut of 2.6 kernels
plus windows. We also must support multiple board versions in the same
files.

Cheers,
   Sean