Thread (7 messages) 7 messages, 4 authors, 2008-05-06

Re: [PATCH 1/4] [v4][POWERPC] refactor dcr code

flat view

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-05-06 04:04:32

On Tue, 2008-05-06 at 13:40 +1000, Stephen Rothwell wrote:
Since find_dcr_parent has done a of_node_get on its return value, you
leak a reference to dp here i.e. you need an of_node_put(dp) before
you return.
He inherited that bug from other dcr.c functions I wrote, my fault.

Stephen (N. not R.), would you mind fixing them while at it or do you
want me to cook up a patch ?

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help