-----Original Message-----
From: David Brownell [mailto:david-b@pacbell.net]
Sent: den 1 maj 2008 00:56
To: Andrew Morton
Cc: spi-devel-general@lists.sourceforge.net; =

joakim.tjernlund@transmode.se; linuxppc-dev@ozlabs.org;

12o3l@tiscali.nl
Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
=20
On Wednesday 30 April 2008, Andrew Morton wrote:

quoted

quoted

+=A0=A0=A0=A0=A0spin_lock_irq(&mpc83xx_spi->lock);

irq-safe.

quoted

...

+=A0=A0=A0=A0=A0spin_lock(&mpc83xx_spi->lock);

not irq-safe.

Deliberate?

=20
That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me.  Maybe Joakim can remove it.

The non irq-safe spin_lock was there before my patch and now it is
removed with the #if 0/#endif block. I don't need this code but
I left it there disabled to make it clear for everyone else
that it was removed. I can remove it but I rather leave it
there for one release so everyone will have a chance to see
it and object if they feel differently.

=20
(By the way, I'd feel safer about this patch if there were an
ack or two from more PPC folk...)

 Yeah, that would be good.

 Jocke