Thread (49 messages) 49 messages, 10 authors, 2008-06-30

Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.

From: Grant Likely <hidden>
Date: 2008-05-24 06:44:15
Also in: linux-spi, lkml

On Wed, May 21, 2008 at 6:17 PM, David Brownell [off-list ref] wrote:
On Friday 16 May 2008, Grant Likely wrote:
quoted
This patch splits the allocation and registration portions of code out
of spi_new_device() and creates three new functions; spi_alloc_device(),
spi_register_device(), and spi_device_release().
I have no problem with the first two, but why the last?

If the devices are always allocated by spi_alloc_device() as
they should be -- probably through an intermediary -- the
only public function necessary for that cleanup should be
the existing spi_dev_put().
Ah, okay.  I'm still a bit fuzzy on the device model conventions.
I'll remove that then.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help