RE: [PATCH 3/4] [MMC] mmc_spi: add polling support for the carddetectline
From: Chen Gong <hidden>
Date: 2008-05-22 13:45:21
Also in:
linux-spi, lkml
=20
-----Original Message----- From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com]=20 Sent: 2008?5?22? 20:39 To: Chen Gong Cc: Kumar Gala; David Brownell; Pierre Ossman;=20 linuxppc-dev@ozlabs.org;=20 spi-devel-general@lists.sourceforge.net;=20 linux-kernel@vger.kernel.org; Tabi Timur Subject: Re: [PATCH 3/4] [MMC] mmc_spi: add polling support=20 for the carddetectline =20 On Mon, May 19, 2008 at 11:02:13AM +0800, Chen Gong wrote:quoted
=20quoted
-----Original Message----- From: linuxppc-dev-bounces+b11801=3Dfreescale.com@ozlabs.org [mailto:linuxppc-dev-bounces+b11801=3Dfreescale.com@ozlabs.org] On Behalf Of Anton Vorontsov Sent: 2008?5?17? 0:51 To: Kumar Gala; David Brownell; Pierre Ossman Cc: linuxppc-dev@ozlabs.org; spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org; Tabi Timur Subject: [PATCH 3/4] [MMC] mmc_spi: add polling support=20for the card=20quoted
quoted
detectline =20 Some boards do not use interrupts on the CD line, so we=20want to poll=20quoted
quoted
the CD and see if there was a change. 1 second poll=20interval seems=20quoted
quoted
resonable. =20 Signed-off-by: Anton Vorontsov <redacted> --- drivers/mmc/host/mmc_spi.c | 51=20=20 I want to know whether every card working well ? Because=20I'm working=20quoted
For 83xx MMC-over-SPI support, the presented concrete=20methods I used=20quoted
as you do, but only 256M card seems good, 512M or 1G/2G=20card all have=20quoted
some problems=20 So far I don't have cards larger than 256M. Will try to get=20 one though. =20
Thanks, if you have any new test report pls contact me. BTW, a fews days ago Joakim Tjernlund made a heavy fix for=20 spi_mpc83xx.c to resolve clock glitch. But it looks no any impact for me, but maybe it has positive effect for you.