RE: [PATCH] ucc_geth: Add 8 bytes to max TX frame for VLANs
flat view
From: Li Yang <hidden>
Date: 2008-03-21 12:20:42
Also in:
netdev
-----Original Message----- From: <redacted> [mailto:netdev-owner@vger.kernel.org] On Behalf Of Joakim Tjernlund Sent: Tuesday, March 18, 2008 11:11 PM To: Netdev; Li Yang Cc: Joakim Tjernlund Subject: [PATCH] ucc_geth: Add 8 bytes to max TX frame for VLANs =20 Creating a VLAN interface on top of ucc_geth adds 4 bytes to=20 the frame and the HW controller is not prepared to TX a frame=20 bigger than 1518 bytes which is 4 bytes too small for a full=20 VLAN frame. Also add 4 extra bytes for future expansion.
IMO, VLAN and Jumbo packet support is not general case of Ethernet.
Could you make this change optional? Thanks.
- Leo
quoted hunk
=20 Signed-off-by: Joakim Tjernlund <redacted> --- drivers/net/ucc_geth.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) =20diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c=20 index 348892b..038ec75 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c@@ -114,10 +114,10 @@ static struct ucc_geth_info=20ugeth_primary_info =3D { .maxGroupAddrInHash =3D 4, .maxIndAddrInHash =3D 4, .prel =3D 7, - .maxFrameLength =3D 1518, + .maxFrameLength =3D 1518+8, /* Add 4 bytes for VLAN tags=20 and 4 extra=20 +bytes */ .minFrameLength =3D 64, - .maxD1Length =3D 1520, - .maxD2Length =3D 1520, + .maxD1Length =3D 1520+8, + .maxD2Length =3D 1520+8, .vlantype =3D 0x8100, .ecamptr =3D ((uint32_t) NULL), .eventRegMask =3D UCCE_OTHER, -- 1.5.4.3 =20 -- To unsubscribe from this list: send the line "unsubscribe=20 netdev" in the body of a message to majordomo@vger.kernel.org=20 More majordomo info at http://vger.kernel.org/majordomo-info.html =20