Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.
From: Laurent Pinchart <hidden>
Date: 2008-03-28 14:07:01
Attachments
- (unnamed) [application/pgp-signature] 189 bytes
From: Laurent Pinchart <hidden>
Date: 2008-03-28 14:07:01
On Friday 28 March 2008 14:58, Laurent Pinchart wrote:
On Thursday 27 March 2008 16:39, Scott Wood wrote:quoted
On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote:quoted
On Wednesday 26 March 2008 17:59, Scott Wood wrote:quoted
This breaks the bootwrapper console.And of course I forgot about that :-) The boot wrapper code doesn't have any dpram allocator. Any objection
against
quoted
quoted
using a chunk of dpram at a fixed location ? What about at the beginning
of
quoted
quoted
the dpram ? The DTS muram node would then exclude a chunk of dpram at
offset
quoted
quoted
0x0000 instead of 0x1100.I'm not entirely comfortable with using a chunk outside of what's in the muram node, and assuming that it's for the SMC pram -- what if there's microcode or something there? Since udbg is only for debugging, and is marked as potentially dangerous, how about just using the end of muram (as described in the device tree)? If the muram is fully allocated, it won't happen until after the real serial console is initialized.Very good idea. I'll prepare a new patch.
arch/powerpc/boot/cpm-serial.c stores the udbg buffer descriptors at the beginning of the muram. Should I move them at the end as well ? -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75