Thread (1 message) 1 message, 1 author, 2008-03-27

[patch 1/6] PS3: Fix unlikely typo in ps3_get_irq

DORMANTno replies

From: Geoff Levand <hidden>
Date: 2008-03-27 00:40:02
Subsystem: linux for powerpc (32-bit and 64-bit), ps3 platform support, the rest · Maintainers: Madhavan Srinivasan, Geoff Levand, Linus Torvalds

From: Roel Kluin <redacted>

Fix a typo bug 'unlikely(x) == y' and add an unlikely() call to
an unlikely code path in the PS3 interrupt routine ps3_get_irq().

Signed-off-by: Roel Kluin <redacted>
Signed-off-by: Geoff Levand <redacted>
---
 arch/powerpc/platforms/ps3/interrupt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -709,7 +709,7 @@ static unsigned int ps3_get_irq(void)
 	asm volatile("cntlzd %0,%1" : "=r" (plug) : "r" (x));
 	plug &= 0x3f;
 
-	if (unlikely(plug) == NO_IRQ) {
+	if (unlikely(plug == NO_IRQ)) {
 		pr_debug("%s:%d: no plug found: thread_id %lu\n", __func__,
 			__LINE__, pd->thread_id);
 		dump_bmp(&per_cpu(ps3_private, 0));
-- 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help