Re: [PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

Hi Heiko,

On Tue, 18 Mar 2008 08:13:06 +0100 Heiko Schocher [off-list ref] wrote:

Stephen Rothwell wrote:

quoted

On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher [off-list ref] wrote:

[...]

quoted

quoted

+struct cpm_pin {
+		int port, pin, flags;
+};

I wish someone would consolidate all these definitions of cpm_pin.

Hmm... do you mean something like, moving this struct
in cpm1.h and ...

Yes or somewhere else appropriate.

quoted

quoted

+	for (i = 0; i < ARRAY_SIZE(mgsuvd_pins); i++) {
+		struct cpm_pin *pin = &mgsuvd_pins[i];
+		cpm1_set_pin(pin->port, pin->pin, pin->flags);
+	}

And the code that uses them ...

making in arch/powerpc/sysdev/cpm1.c a function
cpm1_setup_pins (struct cpm_pin *pins) ?

Yes.

This is not necessary for your patch, but would be a nice cleanup later.
N.B. this struct is alos used by users of cpm2_set_pin().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/