Thread (17 messages) 17 messages, 5 authors, 2008-03-07

Re: [PATCH 3/4] Emerson KSI8560 device tree

From: David Gibson <hidden>
Date: 2008-03-04 23:29:40

On Tue, Mar 04, 2008 at 07:35:40PM +0300, Alexandr Smirnov wrote:
Add device tree file for Emerson KSI8560 board.

Signed-off-by: Alexandr Smirnov <redacted>
[snip]
+		enet0: ethernet@24000 {
+			linux,network-index = <0>;
We're trying to get rid of this.  Since I assume you're using u-boot,
I'm not sure why you'd need it now anyway.
quoted hunk ↗ jump to hunk
+			device_type = "network";
+			model = "TSEC";
+			compatible = "gianfar";
This still looks like the old binding.

[snip]
+		cpld@4,0 {
+			compatible = "altera,maxii";
I'm guessing an Altera Maxii is just the name of the FPGA chip into
which the CPLD is programmed?  If so, it's not a suitable "comaptible"
value, because that needs to describe the register interface.  You
probably want something like
	compatible = "emerson,KSI8560-cpld";
here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help