Re: [PATCH] [POWERPC] CPM1: implement GPIO LIB API

Jochen Friedrich wrote:

Hi Scott,

quoted

quoted

diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig
index 7fd224c..e12cbf0 100644
--- a/arch/powerpc/platforms/8xx/Kconfig
+++ b/arch/powerpc/platforms/8xx/Kconfig

@@ -4,6 +4,8 @@ config FADS
 config CPM1
 	bool
 	select CPM
+	select GENERIC_GPIO
+	select GPIO_LIB

Shouldn't this depend on the user enabling GPIO support?  Some 8xx boards are very memory-constrained, so we don't want to be making the kernel even bigger than it already is unless it's actually needed.

Are you more comfortable with this?

Sure.

-Scott