Re: Use aliases instead of linux,network-index on Ebony
From: Josh Boyer <hidden>
Date: 2008-02-25 11:57:07
On Mon, 25 Feb 2008 17:49:25 +1100 David Gibson [off-list ref] wrote:
On Sun, Feb 24, 2008 at 10:34:43PM -0600, Josh Boyer wrote:quoted
On Mon, 25 Feb 2008 11:33:39 +1100 David Gibson [off-list ref] wrote:quoted
This patch alters the Ebony bootwrapper to use the new preferred method of using aliases to work out which MAC address to attach to which ethernet device node, rather than the old method based on the linux,network-index property.I like it. But do we have this new preferred method documented somewhere? Doesn't seem to be in booting-without-of.txt. It probably should be added there, and reference to the linux,network-index property removed if this is really preferred now. Can you add something to this patch for that?Hrm. linux,network-index was mentioned in b-w-o.txt, but to be honest I don't think it ever belonged there. It describes a bootloader to kernel interface, whereas network-index was always a bootwrapper internal hack, applicable only when the device tree and the fixup code were built into the one image.
That's fine. But can it you remove reference to it then?
aliases, on the other hand do warrent wider mention, and aren't mentioned at all in b-w-o.txt, but that's a matter of larger scope than just getting rid of the network-index hack.
My concern is that people writing new ports will continue to copy DTS files with linux,network-index in it. Particularly since it's recommended in b-w-of.txt, and there is no mentioned alternative. josh