On Sat, 2008-02-23 at 13:34 +1100, Paul Mackerras wrote:

Stefan Roese writes:

quoted

Tested on AMCC Canyonlands eval board.

Signed-off-by: Stefan Roese <sr@denx.de>

With 173 lines of code added, you could spend a paragraph in the patch
description telling us why the patch is doing what it's doing the way
it's doing it.  Perhaps even tell us why it takes 173 new lines of
code to do something that sounds pretty simple - tell us what the
complexities you encountered were.

Actually, the patch just adds a backend to my little framework for
dealing with 4xx PCIe, which basically is a boring piece of code
filling registers with values mostly from the spec... nothing really
fancy there.

Cheers,
Ben.