Re: [RFC][POWERPC] bootwrapper: Add a firmware-independent simpleboot target.

On Feb 8, 2008 4:02 AM, David Gibson [off-list ref] wrote:

On Fri, Feb 01, 2008 at 11:55:42PM -0700, Grant Likely wrote:

quoted

From: Grant Likely <redacted>
+     /* Make sure FDT blob is sane */
+     if (fdt_check_header(_dtb_start) != 0)
+             fatal("Invalid device tree blob\n");

I think most of these fatal()s are pretty pointless.  This is
platform_init(), so the console won't even have been initialized to
actually print any of the messages.  Precisely because this is
simpleboot, in which every bit of information the wrapper has comes
from teh device tree, if the provided blob is so bad as to fail these
basic tests, we're totally stuffed anyway.  It'll take a hardware
debugger to track down, and I don't think the fatal()s will actually
help much at that point.

heh; very true.  I'll kill them.

g.



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.