Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

Doug Maxey wrote:

On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote:

quoted

On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:

quoted

 /* input param R5 */
-#define H_ALL_RES_QP_EQPO         EHEA_BMASK_IBM(9, 11)

...

quoted

quoted

+#define H_ALL_RES_QP_EQPO	  EHEA_BMASK_IBM(9, 11)

...

quoted

This was better the way it was (before, it was readable at any tab setting);
checkpatch is overeager to complain on tab/space issues (it's a bit hard to
distinguish indentation from alignment with a regex).

In emacs, with no special offsets, the lines appear to still line up.

Are you using a tab size other than 8?

What did happen was spaces were turned to tabs where applicable.

I disagree about the applicability. :-)

What editor shows a bad alignment?

Any editor that has been configured to a non-default tab size.

-Scott