Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

On Sat, Feb 02, 2008 at 07:41:02PM +0000, Ben Dooks wrote:

On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote:

quoted

On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote:

quoted

Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM
driver.

CC: linuxppc-dev@ozlabs.org
Signed-off-by: Ben Dooks <ben-linux@fluff.org>

What tree is this against? It doesn't apply to current mainline nor
jgarzik's libata-dev upstream branch.

It is a series that i've just sent to the linux-ide list, only the ppc
part was cc'd to the ppc list.

D'oh. Ok, makes more sense now.

Are you planning on adding HAVE_PATA_PLATFORM to the other archs that
use it as well, or keep it under EMBEDDED there?

quoted

Anyway: NACK: I like this approach but this needs to be added to
arch/powerpc as well.

I can add that to the series.

Ok, cool. We can probably move it in under the relevant powerpc
sub-platforms over time, and that's a powerpc-specific change anyway,
no need to get that through linux-ide.

quoted

It's actually more needed there than arch/ppc, I don't personally care
if arch/ppc can't use pata_platform for the last couple of months it's
still around (it's getting deleted this summer, all platforms should
have moved to powerpc by then).

Thanks, didn't know that.

No problem. :)


-Olof